jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-2749) Closing a session twice shouldn't write a warning in the log
Date Wed, 15 Sep 2010 10:30:35 GMT

    [ https://issues.apache.org/jira/browse/JCR-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909691#action_12909691
] 

Jukka Zitting commented on JCR-2749:
------------------------------------

I looked deeper into this and it looks like the warning from "new TransientRepository().login().logout()"
does not come from this logout() call, but actually from the fact that the repository is attempting
to repeatedly close the system session! This is because of the hacks used in access control
and data store garbage collection code where the system session of a workspace is marked as
a normal active session to prevent the workspace janitor from disposing a workspace. During
shutdown this makes the repository treat the system session as an unclosed user session, which
then gets automatically closed before the repository later on correctly attempts to close
the system session. The system session should only ever get closed in the WorkspaceInfo.doDispose()
method.

Assuming we fix the above problem, is there still a need to keep the log level at debug? As
shown by this case the warnings do help us spot real problems.

> Closing a session twice shouldn't write a warning in the log
> ------------------------------------------------------------
>
>                 Key: JCR-2749
>                 URL: https://issues.apache.org/jira/browse/JCR-2749
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 2.2.0
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: sessionClose.txt
>
>
> When closing a session twice the following warning is written to the log file as of JCR-2741:
> "This session has already been closed. See the chained exception for a trace of where
the session was closed."
> I think the second "close()" should simply be ignored, without warning.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message