jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-2749) Closing a session twice shouldn't write a warning in the log
Date Thu, 16 Sep 2010 03:46:33 GMT

    [ https://issues.apache.org/jira/browse/JCR-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910000#action_12910000

Thomas Mueller commented on JCR-2749:

Thanks for fixing the root cause of the problem!

a) Is it illegal (according to the spec) to call close() multiple times? I think it isn't,
but I might be wrong.

b) The AssertionError was supposed to be thrown calling close() multiple times while running
Jackrabbit test cases only (this is detected using a system property). Personally, I actually
didn't think about using the "assert" keyword, because of a). Instead, I would use "if (runningJackrabbitTestCases)
throw new AssertionError(...)". That means a client would never get this exception, but the
exception would be thrown when running Jackrabbit test cases, no matter if -ea is used or

> Closing a session twice shouldn't write a warning in the log
> ------------------------------------------------------------
>                 Key: JCR-2749
>                 URL: https://issues.apache.org/jira/browse/JCR-2749
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 2.2.0
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>            Priority: Minor
>             Fix For: 2.2.0
>         Attachments: sessionClose.txt
> When closing a session twice the following warning is written to the log file as of JCR-2741:
> "This session has already been closed. See the chained exception for a trace of where
the session was closed."
> I think the second "close()" should simply be ignored, without warning.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message