jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-2749) Closing a session twice shouldn't write a warning in the log
Date Wed, 15 Sep 2010 09:21:34 GMT

    [ https://issues.apache.org/jira/browse/JCR-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909667#action_12909667
] 

Thomas Mueller commented on JCR-2749:
-------------------------------------

If we do really want a warning in the log (which I think is not necessary, I think debug is
enough) then we need both places where the session was closed. Just one stack trace is not
enough.

I think throwing an AssertionError while testing is OK, but how? Do we have a mechanism (maybe
a system property) to distinguish between test and runtime?

> Closing a session twice shouldn't write a warning in the log
> ------------------------------------------------------------
>
>                 Key: JCR-2749
>                 URL: https://issues.apache.org/jira/browse/JCR-2749
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 2.2.0
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>            Priority: Minor
>             Fix For: 2.2.0
>
>
> When closing a session twice the following warning is written to the log file as of JCR-2741:
> "This session has already been closed. See the chained exception for a trace of where
the session was closed."
> I think the second "close()" should simply be ignored, without warning.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message