jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-2750) MultiStatusResponse should not call resource.getProperties
Date Thu, 16 Sep 2010 22:33:33 GMT

    [ https://issues.apache.org/jira/browse/JCR-2750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910364#action_12910364
] 

Jukka Zitting commented on JCR-2750:
------------------------------------

Sounds good to me. Could you formulate the above as a proper patch against the latest Jackrabbit
trunk?

> MultiStatusResponse should not call resource.getProperties
> ----------------------------------------------------------
>
>                 Key: JCR-2750
>                 URL: https://issues.apache.org/jira/browse/JCR-2750
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>            Reporter: Stepan Koltsov
>
> current constructor MultiStatusResponse() calls resource.getProperties() even if propFindType
== PROPFIND_BY_PROPERTY.
> This is inconvenient, because some properties are expensive to generate if they are not
requested. MultiStatusResponse() constructor with parameter PROPFIND_BY_PROPERTY should do:
> ===
> if (propFindType == PROPFIND_BY_PROPERTY) {
>   for (propName : propNameSet) {
>     prop = resource.getProperty(propName);
>     if (prop != null)
>       status200.addContent(prop);
>     else
>       status404.addContent(propName);
>   }
> } else {
>   ...
> }
> ===

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message