jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-2749) Closing a session twice shouldn't write a warning in the log
Date Wed, 15 Sep 2010 11:52:33 GMT

    [ https://issues.apache.org/jira/browse/JCR-2749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909700#action_12909700
] 

Thomas Mueller commented on JCR-2749:
-------------------------------------

Thanks a lot Jukka, great that you found the root cause!

> Assuming we fix the above problem, is there still a need to keep the log level at debug?

For me personally, it's not that important. 

My fear is the log file will be less relevant if it contains stack traces of things that are
viewed as unproblematic by many (most?) developers (such as closing a resource twice). So
I vote to keep it at debug level. 

But I agree with Michael: while running unit tests, it should throw an AssertionError. Therefore,
it would have broke the build.

> Closing a session twice shouldn't write a warning in the log
> ------------------------------------------------------------
>
>                 Key: JCR-2749
>                 URL: https://issues.apache.org/jira/browse/JCR-2749
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: 2.2.0
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: sessionClose.txt
>
>
> When closing a session twice the following warning is written to the log file as of JCR-2741:
> "This session has already been closed. See the chained exception for a trace of where
the session was closed."
> I think the second "close()" should simply be ignored, without warning.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message