Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 35196 invoked from network); 16 Aug 2010 08:31:53 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 16 Aug 2010 08:31:53 -0000 Received: (qmail 86270 invoked by uid 500); 16 Aug 2010 08:31:53 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 85958 invoked by uid 500); 16 Aug 2010 08:31:51 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 85951 invoked by uid 99); 16 Aug 2010 08:31:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Aug 2010 08:31:50 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com designates 209.85.214.170 as permitted sender) Received: from [209.85.214.170] (HELO mail-iw0-f170.google.com) (209.85.214.170) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Aug 2010 08:31:44 +0000 Received: by iwn1 with SMTP id 1so1939554iwn.1 for ; Mon, 16 Aug 2010 01:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:content-type; bh=WC/R4rcRhw9ZeTqF8JLNdn6IGoZZcY1byp98mGRQkIs=; b=rmwmlz0AeX6R80JVYPAqBDeI4TdDX4petKYmkA274OAlI6mTwz1E26tVZiUSp8/EcK PrequxxJLKZHpQ2PTAmxWgGasuih4obKA5T7kyOJHF9+fKch1SBoKFwIdMbin5rJVUZd H8x87Q6glCQcSn6SSIfBhfaCTn0rVAGRrS02M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; b=IQji4bIv786V1Yj5kKioYNd9EdiWreLlOuW9JDOMQiJYBexT4mgzTSm0KDoiAiDdpp 30HoMQ9VCsx9Jok13PfXDEQTQAeja23DvOOB0jdpKPfW5juS32wB6+iqRfXtrijAvDxg p+s7ZJpuJ24IfyGpn7SwgCMJDiY15m/Z7uYdM= Received: by 10.231.14.201 with SMTP id h9mr5531009iba.133.1281947483653; Mon, 16 Aug 2010 01:31:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.144.140 with HTTP; Mon, 16 Aug 2010 01:31:03 -0700 (PDT) In-Reply-To: References: <20100813163657.33A0023889B6@eris.apache.org> From: Jukka Zitting Date: Mon, 16 Aug 2010 10:31:03 +0200 Message-ID: Subject: Re: svn commit: r985273 - in /jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core: ./ state/ version/ To: dev@jackrabbit.apache.org Content-Type: text/plain; charset=ISO-8859-1 Hi, On Mon, Aug 16, 2010 at 10:12 AM, Stefan Guggisberg wrote: > sorry, but i don't agree with these changes. > ItemState classes IMO shouldn't have any > knowledge of node type semantics. OK, I'll move them away from there. My main point with this commit was to get rid of the NodeTypeInstanceHandler member variable in SessionImpl. That class only contained the single computeSystemGeneratedPropertyValues() method, which was essentially a static helper method. Turning it into a member of NodeState seemed like a straightforward approach and the extra method in PropertyState helped simplify calling code. You're right in that I did fail to consider the overall design of the ItemState classes, so I agree that the method should rather be elsewhere. How about putting the logic into NodeTypeRegistry? BR, Jukka Zitting