Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 50679 invoked from network); 16 Aug 2010 09:11:17 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 16 Aug 2010 09:11:17 -0000 Received: (qmail 27893 invoked by uid 500); 16 Aug 2010 09:11:16 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 27652 invoked by uid 500); 16 Aug 2010 09:11:15 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 27645 invoked by uid 99); 16 Aug 2010 09:11:14 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Aug 2010 09:11:14 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com designates 209.85.214.170 as permitted sender) Received: from [209.85.214.170] (HELO mail-iw0-f170.google.com) (209.85.214.170) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Aug 2010 09:11:09 +0000 Received: by iwn1 with SMTP id 1so1976980iwn.1 for ; Mon, 16 Aug 2010 02:10:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:content-type; bh=Dm4R5qzc2nBN7C9NdeC9NhFWKlso/bkPfjJR21AVhmQ=; b=F6Q7I9IuLs6LX69G9MEQCcMW+ZdNK5s06ZcMJRiXOMrfb09Y6rRwDK1SNHofknqrqr qgN4pQ9UtawilzrVkqsvUjYj8TDs7Oti3O2rT/DF2f0uPmAMVbqbC3JRvDMArcGbCUYV JPQX5nsYtVoCn05r3ip3y4tdwtWAqBefkxspI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; b=JRuVjLlgTXA/Ajd4F2KrobbOgzFuqQG1W4CXxXHR8lSNV5n+2V9iv6j42V9vrp0ThB 1jhERgdf9XnehTa+N/wpvJgFemc+pDU5uMqPNJsGvfjJh9EeHrKYqrUHXMsxHqP0xH8o UABtSKiELF0iGsRlErBjs7RiYMeK0x47FHFYA= Received: by 10.231.149.3 with SMTP id r3mr5648724ibv.109.1281949848270; Mon, 16 Aug 2010 02:10:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.144.140 with HTTP; Mon, 16 Aug 2010 02:10:26 -0700 (PDT) In-Reply-To: References: <20100813163657.33A0023889B6@eris.apache.org> From: Jukka Zitting Date: Mon, 16 Aug 2010 11:10:26 +0200 Message-ID: Subject: Re: svn commit: r985273 - in /jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core: ./ state/ version/ To: dev@jackrabbit.apache.org Content-Type: text/plain; charset=ISO-8859-1 Hi, On Mon, Aug 16, 2010 at 10:31 AM, Jukka Zitting wrote: > On Mon, Aug 16, 2010 at 10:12 AM, Stefan Guggisberg > wrote: >> sorry, but i don't agree with these changes. >> ItemState classes IMO shouldn't have any >> knowledge of node type semantics. > > OK, I'll move them away from there. I reverted my earlier changes and committed an alternative solution in revision 985833. The relevant code now stays in NodeTypeInstanceHandler (with the extra helper method I added for setting default property values), but I removed the reference from SessionImpl to NodeTypeInstanceHandler. We may want to reintroduce that reference later if for example we want to make the NodeTypeInstanceHandler pluggable, but for now I'd like to avoid keeping extra stuff in SessionImpl. BR, Jukka Zitting