From dev-return-28708-apmail-jackrabbit-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Fri Jul 02 13:30:46 2010 Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 51188 invoked from network); 2 Jul 2010 13:30:46 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 2 Jul 2010 13:30:46 -0000 Received: (qmail 3992 invoked by uid 500); 2 Jul 2010 13:30:46 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 3797 invoked by uid 500); 2 Jul 2010 13:30:44 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 3784 invoked by uid 99); 2 Jul 2010 13:30:42 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jul 2010 13:30:42 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Jul 2010 13:30:40 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id o62DMnNp009597 for ; Fri, 2 Jul 2010 13:22:49 GMT Message-ID: <23167899.173391278076969303.JavaMail.jira@thor> Date: Fri, 2 Jul 2010 09:22:49 -0400 (EDT) From: "Marcel Reutegger (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Updated: (JCR-2671) AbstractLoginModule must not call abort() in commit() In-Reply-To: <10668703.172771278073249272.JavaMail.jira@thor> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger updated JCR-2671: ---------------------------------- Attachment: JCR-2671.patch Proposed changes and test case. > AbstractLoginModule must not call abort() in commit() > ----------------------------------------------------- > > Key: JCR-2671 > URL: https://issues.apache.org/jira/browse/JCR-2671 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core > Affects Versions: 2.0.0, 2.1.0 > Reporter: Marcel Reutegger > Priority: Minor > Attachments: JCR-2671.patch > > > AbstractLoginModule.commit() currently may call abort() when it detects that the login did not succeed. abort() will reset any state in the login module, including state shared between multiple login modules like Principals in the Subject. When there actually are multiple module, this will delete shared state that was set by other login modules. Moreover, the method commit() is only called when the overall authentication succeeded. Thus, it seems strange to call abort() from within commit(). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.