jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Guggisberg (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (JCR-2648) PropertyImpl.getNode() and NamePropertyTest use different exception than documented in the JCR API JavaDoc
Date Mon, 07 Jun 2010 15:33:40 GMT

     [ https://issues.apache.org/jira/browse/JCR-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stefan Guggisberg resolved JCR-2648.
------------------------------------

    Fix Version/s: 2.2.0
       Resolution: Fixed

fixed in svn r952269

thanks for reporting this issue!

> PropertyImpl.getNode() and NamePropertyTest use different exception than documented in
the JCR API JavaDoc
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: JCR-2648
>                 URL: https://issues.apache.org/jira/browse/JCR-2648
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core, jackrabbit-jcr-tests, JCR 2.0
>    Affects Versions: 2.1.0
>            Reporter: Randall Hauch
>            Assignee: Stefan Guggisberg
>            Priority: Minor
>             Fix For: 2.2.0
>
>
> The Property.getNode() method's JavaDoc [1] lists 3 types of exceptions: ValueFormatException,
ItemNotFoundException, and RepositoryException, and that ItemNotFoundException is to be thrown
when the target node could not be found.  However, the NamePropertyTest.testGetProperty()
method is checking for a PathNotFoundException rather than the documented ItemNotFoundException
(see [2], line 189).  Jackrabbit's implementation in PropertyImpl (see [3] line 539) delegates
to Session.getNode(absolutePath) or Property.getParent().getNode(relativePath), and these
methods are documented as throwing PathNotFoundException (see [4] and [5]).
> Therefore, the unit test and PropertyImpl.getNode() implementation appear to be in disagreement
with the JCR 2.0 API JavaDoc.
> [1] http://www.day.com/maven/javax.jcr/javadocs/jcr-2.0/javax/jcr/Property.html#getNode()
> [2] http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-jcr-tests/src/main/java/org/apache/jackrabbit/test/api/NamePropertyTest.java?revision=772352&view=markup
> [3] http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/PropertyImpl.java?revision=948827&view=markup
> [4] http://www.day.com/maven/javax.jcr/javadocs/jcr-2.0/javax/jcr/Session.html#getNode(java.lang.String)
> [5] http://www.day.com/maven/javax.jcr/javadocs/jcr-2.0/javax/jcr/Node.html#getNode(java.lang.String)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message