Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: pass (nike.apache.org: domain of stefan.guggisberg@gmail.com
 designates 209.85.161.42 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        b=EzLXuKTLTsujMwx0af8EBcfmbPbJnrjvS8p7SwR+DwmnsL38sTsFghcZP+7pPnUnq4
         l4paThTzgD0dQw2NnN1cGBrSetTBwWv+htVU350U0S8XMudWA5Hr/JXDPCvx7U1uh6Z6
         rVhlHT2qTZDxQvVFHS0sEmFMGCjPXzITtj35M=
MIME-Version: 1.0
Sender: stefan.guggisberg@gmail.com
In-Reply-To: <AANLkTimK-bKrUViMSFJP2A9Xo2dZy7jcBgjnLxRzPpkP@mail.gmail.com>
References: <AANLkTilfzfBabbPXH4Zg4_J3TeRAue77wUn6MZuUb3Bh@mail.gmail.com>
	 <AANLkTimK-bKrUViMSFJP2A9Xo2dZy7jcBgjnLxRzPpkP@mail.gmail.com>
Date: Mon, 17 May 2010 11:09:10 +0200
Message-ID: <AANLkTikjjpwd_BOU-zo4bCtpkN7pAQgP6ZmbTE-d31gq@mail.gmail.com>
Subject: Re: FYI: Moving session-related classes to o.a.j.core.session
From: Stefan Guggisberg <stefan.guggisberg@day.com>
To: dev@jackrabbit.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Mon, May 17, 2010 at 11:00 AM, Thomas M=FCller <thomas.mueller@day.com> =
wrote:
> Hi,
>
> I'm not sure if this will help more than it will complicate things.
> Disadvantages:
>
> - Isn't almost every class at in o.a.j.core at least somewhat session rel=
ated?
>
> - If you move classes to other packages, you will have to make many
> method public.

i share tomas's concerns.

>
> Instead of moving session related classes to a separate package, what
> about moving unrelated classes to different packages? For example
> TestContentLoader (>test), RepositoryCopier (>utilities),
> SearchManager (>search), NodeTypeInstanceHandler (>nodetype),
> RepositoryChecker (>persistence), UserPerWorkspaceSecurityManager
> (>security), DefaultSecurityManager (>security), ItemValidator
> (>nodetype).

+1

cheers
stefan

>
> Regards,
> Thomas
>
>
> On Mon, May 17, 2010 at 10:43 AM, Jukka Zitting <jukka.zitting@gmail.com>=
 wrote:
>> Hi,
>>
>> As a part of my work on JCR-890, I'm planning to move most of the
>> session-related classes from o.a.j.core to a new o.a.j.core.session
>> package. This will make it easier to review and control related
>> dependencies and code paths, and to ultimately guard them against
>> access from concurrent threads.
>>
>> As the first step I'm simply moving the relevant classes and making
>> the minor dependency changes where needed, so the functional risk
>> should be low. However, the moves will likely invalidate many other
>> pending jackrabbit-core changes, so please let me know if you have
>> pending changes that I should wait for before I move these classes.
>> Unless there's a need to wait, I'm planning to commit the changes in
>> the afternoon today.
>>
>> BR,
>>
>> Jukka Zitting
>>
>