Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: pass (athena.apache.org: domain of fmeschbe@gmail.com designates
 72.14.220.152 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:subject:references
         :in-reply-to:content-type:content-transfer-encoding;
        b=uERoPPqqnHIGcyCe9RXBaUDQLIrwytd6imI0NuaIC3IguLnWjGCXFqp29UP1GrQrUR
         O2MOS9k9VJn1tryCmVIcC1Ox0bNcLbzOE3wwECE1jTQc8Y6Dp31Xdtbyeqc55SCUdZn6
         Um7QUJ34de1xBMkcID3TbUoOjCAr8ErHe2whE=
Message-ID: <4B868DF2.5070407@gmail.com>
Date: Thu, 25 Feb 2010 15:49:22 +0100
From: Felix Meschberger <fmeschbe@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
 rv:1.9.1.8pre) Gecko/20100120 Shredder/3.0.2pre
MIME-Version: 1.0
To: dev@jackrabbit.apache.org
Subject: Re: [jr3] Synchronized sessions
References: <91f3b2651002241034l3c8495afk188b276f67437534@mail.gmail.com>
	 <4B85860A.8090709@gmail.com>
 <91f3b2651002241219u415fa9a7qfde08ea3b1b5ea09@mail.gmail.com>
In-Reply-To: <91f3b2651002241219u415fa9a7qfde08ea3b1b5ea09@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

On 24.02.2010 21:19, Thomas M=C3=BCller wrote:
> Hi,
>=20
>> deadlocks
>=20
> I think it's relatively simple to synchronize all methods on the sessio=
n.

Yes, but this creates a big potential for deadlocks ...

>=20
>> If we want to make sessions thread-safe, we should use proper
>> implementations.
>=20
> Yes, that's what I want to write: a proper implementation.

I disagree that this would be a proper implementation.

>=20
>> any concurrent use of the same session is unsupported.
>=20
> The disadvantage of this is that there is no way to enforce correct
> usage. In some cases, incorrect usage leads to data corruption. I
> believe data corrupt is not acceptable, even if the user made a
> mistake.

Anything can go wrong -- and if people do the wrong things, well, fine,
let them do ...

And I don't say, we should not make Session thread-safe. But if we set
out to do it, we should do it right. And just synchronizing all methods
is just not right.

Regards
Felix