From dev-return-26987-apmail-jackrabbit-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Wed Feb 03 06:47:45 2010 Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 84265 invoked from network); 3 Feb 2010 06:47:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Feb 2010 06:47:45 -0000 Received: (qmail 63239 invoked by uid 500); 3 Feb 2010 06:47:44 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 63072 invoked by uid 500); 3 Feb 2010 06:47:43 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 63064 invoked by uid 99); 3 Feb 2010 06:47:42 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2010 06:47:42 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2010 06:47:40 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 34ADA29A0019 for ; Tue, 2 Feb 2010 22:47:19 -0800 (PST) Message-ID: <862747569.49371265179639214.JavaMail.jira@brutus.apache.org> Date: Wed, 3 Feb 2010 06:47:19 +0000 (UTC) From: "Thomas Mueller (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Commented: (JCR-2482) Reduce number of compiler warning by adding @Override and generics where appropriate In-Reply-To: <1887866824.28541265127259345.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-2482?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D128289= 81#action_12828981 ]=20 Thomas Mueller commented on JCR-2482: ------------------------------------- I'm wondering if it's really worth adding all those "@Override" lines. My opinion is that it just obfuscates the code, without helping. Similar to= adding 'final' everywhere. To ensure the code is correct, you anyway need automated tests. I'm not saying that the commit should be rolled back, just wondering what o= thers think. I would favor disabling the compiler warning for missing @Override. > Reduce number of compiler warning by adding @Override and generics where = appropriate=20 > -------------------------------------------------------------------------= ------------ > > Key: JCR-2482 > URL: https://issues.apache.org/jira/browse/JCR-2482 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-jcr2spi > Affects Versions: 2.1.0 > Reporter: Michael D=C3=BCrig > Assignee: Michael D=C3=BCrig > Fix For: 2.1.0 > > > Add @Override and generics where possible to reduce the number of warning= s issued by the compiler. --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.