jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-2482) Reduce number of compiler warning by adding @Override and generics where appropriate
Date Wed, 03 Feb 2010 06:47:19 GMT

    [ https://issues.apache.org/jira/browse/JCR-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828981#action_12828981
] 

Thomas Mueller commented on JCR-2482:
-------------------------------------

I'm wondering if it's really worth adding all those "@Override" lines.
My opinion is that it just obfuscates the code, without helping. Similar to adding 'final'
everywhere.
To ensure the code is correct, you anyway need automated tests.

I'm not saying that the commit should be rolled back, just wondering what others think.
I would favor disabling the compiler warning for missing @Override.


> Reduce number of compiler warning by adding @Override and generics where appropriate

> -------------------------------------------------------------------------------------
>
>                 Key: JCR-2482
>                 URL: https://issues.apache.org/jira/browse/JCR-2482
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-jcr2spi
>    Affects Versions: 2.1.0
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>             Fix For: 2.1.0
>
>
> Add @Override and generics where possible to reduce the number of warnings issued by
the compiler.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message