Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 50900 invoked from network); 19 Nov 2009 13:15:03 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 19 Nov 2009 13:15:03 -0000 Received: (qmail 32760 invoked by uid 500); 19 Nov 2009 13:15:02 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 32675 invoked by uid 500); 19 Nov 2009 13:15:02 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 32663 invoked by uid 99); 19 Nov 2009 13:15:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Nov 2009 13:15:02 +0000 X-ASF-Spam-Status: No, hits=-10.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Nov 2009 13:15:00 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 29B11234C1EF for ; Thu, 19 Nov 2009 05:14:40 -0800 (PST) Message-ID: <872864636.1258636480169.JavaMail.jira@brutus> Date: Thu, 19 Nov 2009 13:14:40 +0000 (UTC) From: "Martijn Hendriks (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Assigned: (JCR-1450) move method of the MemoryFileSystem may accept invalid destination path resulting in invalid entries in FS In-Reply-To: <512569811.1204629400673.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/JCR-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Hendriks reassigned JCR-1450: ------------------------------------- Assignee: (was: Martijn Hendriks) > move method of the MemoryFileSystem may accept invalid destination path resulting in invalid entries in FS > ---------------------------------------------------------------------------------------------------------- > > Key: JCR-1450 > URL: https://issues.apache.org/jira/browse/JCR-1450 > Project: Jackrabbit Content Repository > Issue Type: Bug > Components: jackrabbit-core > Affects Versions: 1.4, core 1.4.1, core 1.4.2, core 1.4.3, core 1.4.4 > Reporter: Denis Linine > Priority: Trivial > Fix For: core 1.4.5 > > > It seems there can be a problem with the move method of the MemoryFileSystem class: when looking at its code it looks that it can accept destinations, specifying folders that do not exist in the file system. > For example, if there is a "somefolder/somefile" file and I call the method passing, say "somefolder/someotherfolder/somefile" as the destination. The destination will be accepted by the code even if "somefolder/someotherfolder" is not an existing folder and the function execution will result in a file having the "somefolder/someotherfolder/somefile" path within a file system having no "somefolder/someotherfolder" folder - the code should probably check whether the destination path is really a valid one. Such validation could be performed , for example, in the following way: take all path elements from the destination path except the last one and insure that the resulting path points to an existing folder, throw an exception otherwise. > Currently I have no JackRabbit build/test environment set up and could not verify practically whether the issue described can really take place, the supposition is made after looking at the move method implementation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.