jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn Hendriks (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1456) Database connection pooling
Date Thu, 12 Nov 2009 12:41:39 GMT

    [ https://issues.apache.org/jira/browse/JCR-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776975#action_12776975
] 

Martijn Hendriks commented on JCR-1456:
---------------------------------------

(Sorry for the late reply...)

> Strange is that Connection.getAutoCommit() is called so much (maybe 50% of all JDBC method
calls). Sometimes it is called 4 times in a row

The commons-dbcp pool calls getAutoCommit on each borrow and on each return and ConnectionHelper.getConnection
also calls it. That's three. I agree that the number of calls to getAutoCommit is very large:
28756 vs 759 on the trunk for the tests.

> I just tested H2 embedded. I don't know why H2 got slower in your case

I see the same: H2 embedded is just a couple of seconds slower. Using H2 in server mode over
TCP (localhost), however, (using tracing or not) is significantly slower. This might have
something to do with the large number of getAutoCommit calls....?

> The AutoCommit stuff shouldn't be needed with connection pooling anymore, the AutoCommit
mode should simply always be off. 

I don't think that changing the default for autoCommit changes the number of calls to getAutoCommit.
Can we just keep this default or is there another reason to make the default "false"?


> Database connection pooling
> ---------------------------
>
>                 Key: JCR-1456
>                 URL: https://issues.apache.org/jira/browse/JCR-1456
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Jukka Zitting
>             Fix For: 2.0.0
>
>         Attachments: 777490.patch, dbcp.patch, dbcp.patch, JCR-1456-performance-trunk-test-setup.patch,
JCR-1456-performance.txt, JCR-1456.patch, patch-1456-1.txt, patch-1456-2.txt, patch-1456-3.txt
>
>
> Jackrabbit should use database connection pools instead of a single connection per persistence
manager, cluster journal, or database data store.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message