Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <460842165.1256233019498.JavaMail.jira@brutus>
Date: Thu, 22 Oct 2009 17:36:59 +0000 (UTC)
From: "angela (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Commented: (JCR-2195) Provide possibility to import
 protected items using Session/Workspace import functionality
In-Reply-To: <976644691.1247065275234.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/JCR-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768770#action_12768770 ] 

angela commented on JCR-2195:
-----------------------------

revision 828791:

- add configuration (to the workspace configuration)
- pass config to both SessionImporter and WorkspaceImporter
  (the latter hasn't been touched yet to support this kind of extension and throws unsupported...exc. in case
   it finds configured importers that are meant to be used with a workspace import).
- handling of reference properties
- uuidbehavior passed to the importers


TODOs:
- workspace import

> Provide possibility to import protected items using Session/Workspace import functionality
> ------------------------------------------------------------------------------------------
>
>                 Key: JCR-2195
>                 URL: https://issues.apache.org/jira/browse/JCR-2195
>             Project: Jackrabbit Content Repository
>          Issue Type: New Feature
>          Components: jackrabbit-core, xml
>            Reporter: angela
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: JCR-2195.patch
>
>
> SessionImporter and WorkspaceImporter currently skip all protected items encountered during import except for some special cases
> (see JCR-2172 and WorkspaceImporter#postProcessNode).
> The specification only mandates that protected content is treated in a consistent manner, but allows the implementation to either import or ignore it.
> Find attached a patch containing some initials steps to allow to extend the default import behavior:
> Instead of skipping protected items (and in case of nodes the complete tree below it), they should be passed to a separate handler,
> that may or may not be able to deal with them and needs to assert, that they are in a valid format.
> The patch includes:
> - Abstract classes for that protected item import
> - Default implementations that never import protected nodes (same behavior as we have today)
> - An example implementation for the AC-content (just to see if it works for simple cases) + some trivial tests.
> - Changes to SessionImporter to demonstrate how import of protected items would be enabled.
> The patch doesn't include yet:
> - Changes to WorkspaceImporter (would +- be according to SessionImporter)
> - Changes to WorkspaceImpl/SessionImpl as well as configuration that would allow to modify the default behavior.
> - Examples for import of protected properties.
> - Examples for workspace import.
> The patch has the following limitations or TODOs:
> - Proper handling of protected references properties or non-protected ref properties with the tree defined by a protected node.
> - Test / Careful review if the various ImportUUIDBehaviors are/can properly be covered, specially in case of "replace-existing".
> The patch in addition addresses:
> - An inconsistency in the SessionImporter:
>   > Attempt to import protected content below an existing protected node => skipped
>   > Attempt to import protected content that doesn't yet exist => first node is imported, ConstraintViolationException for child-nodes.
>   > This behavior is also reflected in the Node-stack... where in the first case 'null' is pushed, in the second case the first protected node.
>      (see also JCR-2172 for details).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.