Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Received-SPF: pass (athena.apache.org: domain of jukka.zitting@gmail.com
 designates 209.85.132.241 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type:content-transfer-encoding;
        b=T8LBgrTnpa0YmWMFMpHfjm5C8cUb8h3mR+F1JS2LYB2MLjghp21h5jBffowMwr46uu
         Kam5plC//QR7+u5O8c23kn98XjgCWIOQpaOJQb1l4JsAOkrx6bgWr3XKI+3eC/0T+v/b
         R9XZIgUishlZ/JeqvJirusN8yDMjnTafTX7gA=
MIME-Version: 1.0
In-Reply-To: <91f3b2650909080832icd874a7u9817df3869ee6f6c@mail.gmail.com>
References: <7A5837CEF4D4834E97721F3BCC46D7F71BECAA7D33@darth-malak.gx.local>
	<91f3b2650909070820t5656093fr8d5087366211e395@mail.gmail.com>
	<7A5837CEF4D4834E97721F3BCC46D7F71BEC745868@darth-malak.gx.local>
	<91f3b2650909080832icd874a7u9817df3869ee6f6c@mail.gmail.com>
From: Jukka Zitting <jukka.zitting@gmail.com>
Date: Tue, 8 Sep 2009 18:12:02 +0200
Message-ID: <510143ac0909080912q44dcc955nea98848bae62a829@mail.gmail.com>
Subject: Re: JCR 1456 Database connection pooling
To: dev@jackrabbit.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi,

I merged all the recent changes from trunk to the JCR-1456 branch.
This makes it easier to compare the branch against the trunk and
eventually to merge the pooling changes back to trunk.

On Tue, Sep 8, 2009 at 5:32 PM, Thomas M=FCller<thomas.mueller@day.com> wro=
te:
>> You do need the commons-dbcp library on your classpath
>
> I don't know if this acceptable, probably it is. So you would need
> commons-dbcp-1.2.2.jar, which is 120 KB. What about commons-pool, or
> other dependencies of commons-dbcp?

We've typically added or changed a few dependencies in each minor
release and doing that in Jackrabbit 2.0 is quite OK.

The size of commons-dbcp and it's dependencies is pretty small
compared to things like the new POI libraries we're adding in 2.0 to
implement full text indexing of  OOXML documents.

>> it is retrieved every time it is needed from a pooling DataSource.
>
> Do you know how much this slows down operations? Probably we should
> try to measure this.

Agreed, though intuitively the effect of pooling should be negligible
(a few extra method calls and hash lookups compared to the work that
happens in the underlying database).

BR,

Jukka Zitting