Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <2092381076.1254297752078.JavaMail.jira@brutus>
Date: Wed, 30 Sep 2009 01:02:32 -0700 (PDT)
From: "angela (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Updated: (JCR-2333) ItemImpl#validateTransientItems:
 Incomplete validation of mandatory child item
In-Reply-To: <196138248.1254153796298.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/JCR-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela updated JCR-2333:
------------------------

    Attachment: JCR-2333_2.patch

alternative patch accessing the ItemData instead of the Item itself in order to retrieve the definition.
drawback: ItemManager#getItemData was private -> changed.

> ItemImpl#validateTransientItems: Incomplete validation of mandatory child item
> ------------------------------------------------------------------------------
>
>                 Key: JCR-2333
>                 URL: https://issues.apache.org/jira/browse/JCR-2333
>             Project: Jackrabbit Content Repository
>          Issue Type: Bug
>          Components: jackrabbit-core
>            Reporter: angela
>             Fix For: 2.0.0
>
>         Attachments: JCR-2333_2.patch, JCR_2333.patch
>
>
> ItemImpl#validateTransientItems iterates over all mandatory child node/property definitions in order to assert that those items have
> been created. However, it only checks if an item with the name defined by the mandatory item definition is present and not if that
> existing item really has the mandatory definition.
> the example i had:
> - mandatory single-value property.
> - there is the possibility to add residual props
> - added a residual property with the name of the mandatory prop but with multiple values
> -> changes are saved without exception.
> -> the node doesn't have a property with the mandatory definition.
> ((without having tried it out, i think the same would be possible with child nodes))
> suggested fix:
> if there is a child item with the mandatory-item-name -> make sure it's definition is mandatory (or the expected one...)
> patch will follow.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.