jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] Created: (JCR-2333) ItemImpl#validateTransientItems: Incomplete validation of mandatory child item
Date Mon, 28 Sep 2009 16:03:16 GMT
ItemImpl#validateTransientItems: Incomplete validation of mandatory child item
------------------------------------------------------------------------------

                 Key: JCR-2333
                 URL: https://issues.apache.org/jira/browse/JCR-2333
             Project: Jackrabbit Content Repository
          Issue Type: Bug
          Components: jackrabbit-core
            Reporter: angela
             Fix For: 2.0.0


ItemImpl#validateTransientItems iterates over all mandatory child node/property definitions
in order to assert that those items have
been created. However, it only checks if an item with the name defined by the mandatory item
definition is present and not if that
existing item really has the mandatory definition.

the example i had:
- mandatory single-value property.
- there is the possibility to add residual props
- added a residual property with the name of the mandatory prop but with multiple values

-> changes are saved without exception.
-> the node doesn't have a property with the mandatory definition.

((without having tried it out, i think the same would be possible with child nodes))

suggested fix:
if there is a child item with the mandatory-item-name -> make sure it's definition is mandatory
(or the expected one...)
patch will follow.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message