Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 62800 invoked from network); 4 May 2009 07:57:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 May 2009 07:57:54 -0000 Received: (qmail 86692 invoked by uid 500); 4 May 2009 07:57:53 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 86624 invoked by uid 500); 4 May 2009 07:57:53 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 86616 invoked by uid 99); 4 May 2009 07:57:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2009 07:57:53 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2009 07:57:51 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 635D0234C003 for ; Mon, 4 May 2009 00:57:30 -0700 (PDT) Message-ID: <1172713957.1241423850395.JavaMail.jira@brutus> Date: Mon, 4 May 2009 00:57:30 -0700 (PDT) From: =?utf-8?Q?Michael_D=C3=BCrig_=28JIRA=29?= To: dev@jackrabbit.apache.org Subject: [jira] Commented: (JCR-2096) Move jcr2spi tests to spi2jcr In-Reply-To: <943536374.1241422890289.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-2096?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D127055= 14#action_12705514 ]=20 Michael D=C3=BCrig commented on JCR-2096: ------------------------------------ AFAIR the current approach was chosen such that the jcr2spi tests can be re= -used for other SPI implementations. > Move jcr2spi tests to spi2jcr > ----------------------------- > > Key: JCR-2096 > URL: https://issues.apache.org/jira/browse/JCR-2096 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-jcr2spi, jackrabbit-spi2jcr, test > Reporter: Jukka Zitting > > Currently we have a number of test cases included in the jcr2spi componen= t, but they aren't being run in there (surefire plugin is disabled). Instea= d, the tests are packaged into a -tests jar that is then used in the spi2jc= r component to run them. > The downside of this setup are 1) extra complexity and 2) the fact that a= -Dmaven.test.skip=3Dtrue build will not work with a clean Maven repository= as the jcr2spi -tests jar is not being built for spi2jcr. > How about if we simply moved the tests to the spi2jcr component where the= y are being used? --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.