From dev-return-23239-apmail-jackrabbit-dev-archive=jackrabbit.apache.org@jackrabbit.apache.org Mon May 04 08:01:59 2009 Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 63741 invoked from network); 4 May 2009 08:01:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 May 2009 08:01:59 -0000 Received: (qmail 90624 invoked by uid 500); 4 May 2009 08:01:58 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 90551 invoked by uid 500); 4 May 2009 08:01:58 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 90543 invoked by uid 99); 4 May 2009 08:01:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2009 08:01:58 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2009 08:01:57 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 4B172234C4B2 for ; Mon, 4 May 2009 01:01:37 -0700 (PDT) Message-ID: <1031103074.1241424097306.JavaMail.jira@brutus> Date: Mon, 4 May 2009 01:01:37 -0700 (PDT) From: "Jukka Zitting (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Commented: (JCR-2096) Move jcr2spi tests to spi2jcr In-Reply-To: <943536374.1241422890289.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705517#action_12705517 ] Jukka Zitting commented on JCR-2096: ------------------------------------ I figured as much, but we could achieve the same result by enabling the -tests jar to be built from spi2jcr. Or alternatively the tests could be pushed either to jcr-tests or to a new spi-tests component based on their nature. > Move jcr2spi tests to spi2jcr > ----------------------------- > > Key: JCR-2096 > URL: https://issues.apache.org/jira/browse/JCR-2096 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-jcr2spi, jackrabbit-spi2jcr, test > Reporter: Jukka Zitting > > Currently we have a number of test cases included in the jcr2spi component, but they aren't being run in there (surefire plugin is disabled). Instead, the tests are packaged into a -tests jar that is then used in the spi2jcr component to run them. > The downside of this setup are 1) extra complexity and 2) the fact that a -Dmaven.test.skip=true build will not work with a clean Maven repository as the jcr2spi -tests jar is not being built for spi2jcr. > How about if we simply moved the tests to the spi2jcr component where they are being used? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.