jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1525) Jackrabbit depends on Oracle driver for BLOB support in Oracle versions previous than 10.2
Date Mon, 18 May 2009 07:22:45 GMT

    [ https://issues.apache.org/jira/browse/JCR-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710294#action_12710294
] 

Thomas Mueller commented on JCR-1525:
-------------------------------------

+1 for the patch except:

The class names should match the names used in the bundle PMs. Currently the patch uses:
Oracle10R2FileSystem (for Oracle 10 and newer)
OracleFileSystem (for Oracle 9)

The class names should be:
OracleFileSystem (for Oracle 10 and newer)
Oracle9FileSystem (for Oracle 9)


> Jackrabbit depends on Oracle driver for BLOB support in Oracle versions previous than
10.2
> ------------------------------------------------------------------------------------------
>
>                 Key: JCR-1525
>                 URL: https://issues.apache.org/jira/browse/JCR-1525
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Esteban Franqueiro
>         Attachments: JCR-1525.patch
>
>
> In Oracle versions previous to 10.2, Jackrabbit explicitly uses a class from the Oracle
driver to provide BLOB support (see OracleFileSystem.init()). This special handling is no
longer necesary for Oracle 10.2+, so we should provide a new implementation. As discussed
on the list, we can create a new class for Oracle 10.2+, make it inherit from DbFileSystem,
and override the createSchema(), and table space related methods, which are the ones that
need special handling. Furthermore, we could refactor the current OracleFileSystem and break
it into two clases, one of them to keep the current behavior and a new one to keep the common
code (which we could rename to OracleBaseFileSystem or similar, to maintain compatiblity with
code that uses OracleFileSystem for versions previous to 10.2). Then we make the Oracle10FileSystem
inherit from the latter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message