jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1456) Database connection pooling
Date Thu, 14 May 2009 20:37:45 GMT

    [ https://issues.apache.org/jira/browse/JCR-1456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709572#action_12709572
] 

Jukka Zitting commented on JCR-1456:
------------------------------------

> The problem here is that BundleDbPersistenceManager superclass is connection
> agnostic so passing the database connection as argument doesn't seem to be an option.

We can always change the superclass.

> Storing that as member variable is, but it requires additional locking.

Not if it's a member of an extra object that's instantiated per each top level method call.

> As far as I can remember all introduced configuration entities were completely optional
> with sane default making the change pretty much transparent for user. 

For now I'm mostly worried about  the patch being more complex than it needs to be. We can
add config entries once the basic functionality is in place.

> What's the point of hardwiring concrete connection pool?

So we don't need to implement one. Note that the solution should work with existing Jackrabbit
configurations that do not specify a connection pool. There's no need for DBCP when a JNDI
DataSource is configured, but it makes things a lot easier for non-JNDI configurations.

> In my previous patch I didn't attempt to do any connection pooling.

What's SimplePoolingConnectionProvider for then?

> The reason why I chose not to use DataSource is because DataSource has no means to
> pass connection properties (url, driver, etc).

That's what we'd use Commons DBCP for (in cases when a JNDI DataSource has not already been
configured).

> The custom sandbox could work for me.

OK, good. I created such a development branch in https://svn.apache.org/repos/asf/jackrabbit/sandbox/JCR-1456.



> Database connection pooling
> ---------------------------
>
>                 Key: JCR-1456
>                 URL: https://issues.apache.org/jira/browse/JCR-1456
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Jukka Zitting
>         Attachments: patch-1456-1.txt, patch-1456-2.txt, patch-1456-3.txt
>
>
> Jackrabbit should use database connection pools instead of a single connection per persistence
manager, cluster journal, or database data store.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message