jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-2098) SPI layer should only pass through supported repository descriptors
Date Wed, 06 May 2009 14:07:30 GMT

    [ https://issues.apache.org/jira/browse/JCR-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12706439#action_12706439

Jukka Zitting commented on JCR-2098:

> the JCR2SPI layer MUST be able to deal with all functionality and options that can occur
> with a specific version of the JCR API. 

That's a good goal, but as long as the SPI layer does not support all functionality, it should
also not advertise support for such functionality even if the underlying repository does so.

The background for this issue is the new TCK test code that tests for JCR 2.0 features. The
test cases should check the corresponding repository descriptor before attempting to run those
tests. Without this filtering of the descriptors the SPI layer would advertise support for
features it doesn't yet support, causing more TCK test failures.

> The suggested fix just works around that lack and I find it only acceptable as a temporary

Agreed. We can remove the filters as we go about implementing the missing features.

> Jukka, could you mark the corresponding code accordingly? 

Done in revision 772267.

> SPI layer should only pass through supported repository descriptors
> -------------------------------------------------------------------
>                 Key: JCR-2098
>                 URL: https://issues.apache.org/jira/browse/JCR-2098
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-jcr2spi, jackrabbit-spi2jcr
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
> As we add new the JCR 2.0 conformance tests to jcr-tests (see JCR-208) there will be
spi2jcr test failures as the SPI layer has not been updated to support all these new features.
The SPI layer should reflect that by only passing through those repository descriptors that
it can support.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message