jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-2094) Use an enumeration for QOM operators
Date Fri, 01 May 2009 13:12:30 GMT

    [ https://issues.apache.org/jira/browse/JCR-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704984#action_12704984

Jukka Zitting commented on JCR-2094:

Yes, I've already filed a bug with a patch against the PFD.

However, to reduce the number of intermediate JCR 2.0 jars we'd need, I think it makes sense
to use some simple workarounds in Jackrabbit that can easily be removed once a fixed version
of the JCR 2.0 jar is available.

More notably, regardless of the PFD issue, I think it makes quite a lot of sense to use type-safe
enumerations over plain string constants where possible.

> Use an enumeration for QOM operators
> ------------------------------------
>                 Key: JCR-2094
>                 URL: https://issues.apache.org/jira/browse/JCR-2094
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core, jackrabbit-spi-commons, query
>            Reporter: Jukka Zitting
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 2.0.0
> The PFD version of QueryObjectModelConstants contains some incorrect constant values
that make it unusable as a source of operator constants.
> Since we are now using Java 5, I propose that instead of adding our own replacement constant
strings, we implement a type-safe Operator enumeration that contains fixed versions of all
the operator constants declared in QueryObjectModelConstants.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message