jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (JCR-2041) Create Jcr-Client Module
Date Wed, 25 Mar 2009 08:04:51 GMT

    [ https://issues.apache.org/jira/browse/JCR-2041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689025#action_12689025
] 

angela edited comment on JCR-2041 at 3/25/09 1:04 AM:
------------------------------------------------------

> One thing I noted: RepositoryFactoryImpl.getRepository(Map parameters) should handle
the case 
> where parameters == null. In that case it should return a default repository instance.


ok.

> Could this be jr-core?

sure, it could. but then the factory should also be able to deal with core-specific parameters
(see the RepositoryFactory in jackrabbit-core), shouldn't it? otherwise it looks strange to
me.

up to now i thought of the jcr-client as an entry point for the jcr2spi repository only...
but there is no strong reason apart from the fact that we kept jr-core and jr-jcr2spi separate
and that jr-core already has a factory implementation.

alternatively we may define one of the SPI implementations to be the default. in this case
i would opt for the spi2davex.

      was (Author: anchela):
    > One thing I noted: RepositoryFactoryImpl.getRepository(Map parameters) should handle
the case 
> where parameters == null. In that case it should return a default repository instance.


ok.

> Could this be jr-core?

sure, it could. but then the factory should also be able to deal with core-specific parameters
(see the RepositoryFactory in jackrabbit-core), shouldn't it? otherwise it looks strange to
me.

up to now i thought of the jcr-client as an entry point for the jcr2spi repository only...
but there is no strong reason apart from the fact that we kept jr-core and jr-jcr2spi separate
and that jr-core already has a factory implementation.
  
> Create Jcr-Client Module
> ------------------------
>
>                 Key: JCR-2041
>                 URL: https://issues.apache.org/jira/browse/JCR-2041
>             Project: Jackrabbit Content Repository
>          Issue Type: New Feature
>            Reporter: angela
>            Priority: Minor
>             Fix For: 1.6.0
>
>         Attachments: JCR-2041.diff
>
>
> task copied from JCR-1877:
> i think it would be wise to create a new module that mainly consists of a RepositoryFactory
and combines jackrabbit-jcr2spi with the known (and also any other) spi implementations.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message