jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1989) AppendRecord writes single bytes to disk
Date Thu, 19 Feb 2009 12:32:05 GMT

    [ https://issues.apache.org/jira/browse/JCR-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674981#action_12674981
] 

Jukka Zitting commented on JCR-1989:
------------------------------------

+1 Simple and effective.

On a related note, the DeferredFileOutputStream from Commons IO does pretty much the same
thing as the custom memory buffering we have in the AppendRecord class. There's no need to
change the code now, but leveraging the DeferredFileOutputStream might be a good idea if we
ever find other issues with the current code or want to refactor things.

> AppendRecord writes single bytes to disk
> ----------------------------------------
>
>                 Key: JCR-1989
>                 URL: https://issues.apache.org/jira/browse/JCR-1989
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Marcel Reutegger
>            Priority: Minor
>         Attachments: JCR-1989.patch
>
>
> The AppendRecord initially buffers writes in memory and starts
> to write it to a temp file as soon as it occupies more than
> 64k heap. After switching to the temp file, data is written
> unbuffered.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message