jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (JCR-1934) DbDataStore: delete temporary files using finalize()
Date Tue, 03 Feb 2009 10:15:59 GMT

     [ https://issues.apache.org/jira/browse/JCR-1934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas Mueller resolved JCR-1934.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 1.6.0

Committed in revision 740262 (trunk).
Temporary files are now deleted when the input stream is garbage collected.
Database resources are released when the input stream is garbage collected.

> DbDataStore: delete temporary files using finalize()
> ----------------------------------------------------
>
>                 Key: JCR-1934
>                 URL: https://issues.apache.org/jira/browse/JCR-1934
>             Project: Jackrabbit Content Repository
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>             Fix For: 1.6.0
>
>
> Currently, reading from the DbDataStore creates a temporary file by default. If the application
doesn't fully read or close the input stream, the file is not deleted. The best solution is
to use finally { in.close() } in the application, but this is easily forgotten.
> I suggest to delete the temp file using finalize(). There is a small performance penalty
when creating the temporary object, but compared to I/O it is very small. Note that FileInputStream
and FileOutputStream also use finalize().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message