jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn Hendriks (JIRA)" <j...@apache.org>
Subject [jira] Created: (JCR-1948) Let the AbstractISMLockingTest tests fail properly
Date Thu, 22 Jan 2009 09:59:59 GMT
Let the AbstractISMLockingTest tests fail properly
--------------------------------------------------

                 Key: JCR-1948
                 URL: https://issues.apache.org/jira/browse/JCR-1948
             Project: Jackrabbit Content Repository
          Issue Type: Improvement
          Components: test
            Reporter: Martijn Hendriks


The tests in the AbstractISMLockingTest class call junit.framework.Assert.fail() on threads
that are not managed by the JUnit framework. Therefore, such calls to fail are not interpreted
as test failures, but are merely logged to the console and the build succeeds. This is easy
to see with a stub implementation of the ISMLocking type which returns non-null references
from the two acquire methods and the downgrade method: many of the following stacktraces appear,
but the build succeeds.

Exception in thread "Thread-1" junit.framework.AssertionFailedError: acquireWriteLock must
block
	at junit.framework.Assert.fail(Assert.java:47)
	at org.apache.jackrabbit.core.state.AbstractISMLockingTest.checkBlocking(AbstractISMLockingTest.java:214)
	at org.apache.jackrabbit.core.state.AbstractISMLockingTest$1.run(AbstractISMLockingTest.java:88)
	at java.lang.Thread.run(Thread.java:613)




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message