Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 86317 invoked from network); 5 Nov 2008 14:02:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Nov 2008 14:02:07 -0000 Received: (qmail 93056 invoked by uid 500); 5 Nov 2008 14:02:12 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 93034 invoked by uid 500); 5 Nov 2008 14:02:12 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 93023 invoked by uid 99); 5 Nov 2008 14:02:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Nov 2008 06:02:12 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Nov 2008 14:01:03 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 680DA234C278 for ; Wed, 5 Nov 2008 06:01:45 -0800 (PST) Message-ID: <2126167450.1225893705411.JavaMail.jira@brutus> Date: Wed, 5 Nov 2008 06:01:45 -0800 (PST) From: "Alexander Klimetschek (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Issue Comment Edited: (JCR-1847) Path methods should throw NameEx instead of RepositoryEx In-Reply-To: <164666118.1225891424180.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12645220#action_12645220 ] alexander.klimetschek edited comment on JCR-1847 at 11/5/08 5:59 AM: --------------------------------------------------------------------- Ok, that's why I noted to maybe use another specific exception. That one would have to be created in spi then. Or turn it around and not use the spi interfaces as utility methods in internal code (such as the mentioned ObservationManagerImpl, where the Path interface is used for parsing + checking path strings passed in the normal JCR API), but create another Path utility interface for that. was (Author: alexander.klimetschek): Ok, that's why a noted to maybe use another specific exception. That one would have to be created in spi then. Or turn it around and not use the spi interfaces as utility methods in internal code (such as the mentioned ObservationManagerImpl, where the Path interface is used for parsing + checking path strings passed in the normal JCR API. > Path methods should throw NameEx instead of RepositoryEx > -------------------------------------------------------- > > Key: JCR-1847 > URL: https://issues.apache.org/jira/browse/JCR-1847 > Project: Jackrabbit > Issue Type: Improvement > Components: jackrabbit-spi > Reporter: Alexander Klimetschek > Priority: Minor > > The o.a.j.spi.Path interface declares most methods to throw a RepositoryEx, whereas a o.a.j.spi.commons.conversion.NameEx (or another specific exception) would make more sense, since the RepositoryEx is too generic for what seems to be a "malformed names/path" nature for all things that happen in a Path implementation. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.