Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 51275 invoked from network); 17 Nov 2008 20:43:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Nov 2008 20:43:06 -0000 Received: (qmail 33955 invoked by uid 500); 17 Nov 2008 20:43:13 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 33918 invoked by uid 500); 17 Nov 2008 20:43:13 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 33901 invoked by uid 99); 17 Nov 2008 20:43:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Nov 2008 12:43:13 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Nov 2008 20:41:59 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 6E5A3234C28F for ; Mon, 17 Nov 2008 12:42:44 -0800 (PST) Message-ID: <1270233665.1226954564450.JavaMail.jira@brutus> Date: Mon, 17 Nov 2008 12:42:44 -0800 (PST) From: "Christophe Lombart (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Closed: (JCR-1853) Modified QueryImpl to enable external query builders to read and write JCR expressions in the orderBy Clause In-Reply-To: <694665944.1226567444510.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christophe Lombart closed JCR-1853. ----------------------------------- Resolution: Fixed Patch applied. Thanks Let me know if something is wrong. You can close the issue if the commit is good for you > Modified QueryImpl to enable external query builders to read and write JCR expressions in the orderBy Clause > ------------------------------------------------------------------------------------------------------------ > > Key: JCR-1853 > URL: https://issues.apache.org/jira/browse/JCR-1853 > Project: Jackrabbit > Issue Type: Improvement > Components: jackrabbit-ocm > Affects Versions: 1.5.0 > Reporter: Shrirang > Assignee: Christophe Lombart > Fix For: 1.6.0 > > Attachments: OrderByPatch.patch > > > The QueryImpl does not create the JCR expression on the fly. The OrderByExpression does the job. If an external querybuilder class needs to dynamically collect properties against which order by is required, QueryImpl does not support updating the JCR Expression. It can only return the built expression since arrayList is used for collecting the properties. The change enables one to add JCRExpression to the QueryImpl object. A test has been added. > Changed files: > Path > src/main/java/org/apache/jackrabbit/ocm/query/impl/QueryImpl.java > src/test/java/org/apache/jackrabbit/ocm/manager/query/DigesterSimpleQueryTest.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.