Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <1963322887.1223385344368.JavaMail.jira@brutus>
Date: Tue, 7 Oct 2008 06:15:44 -0700 (PDT)
From: "Thomas Mueller (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Updated: (JCR-1788) Maven variable collision
In-Reply-To: <1500999838.1223381624388.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/JCR-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Mueller updated JCR-1788:
--------------------------------

    Environment: maven 2.0.9, 2.1.0-M1  (was: Leopard, maven 2.1.0-M1)

The same problem occurs with Maven 2.0.9 and Windows XP. The 'wsp' prefix doesn't seem to be the problem: 
Even ${abc.name} is replaced with the project name. However ${jr.wsp.name} is not replaced.

> Maven variable collision
> ------------------------
>
>                 Key: JCR-1788
>                 URL: https://issues.apache.org/jira/browse/JCR-1788
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: config
>         Environment: maven 2.0.9, 2.1.0-M1
>            Reporter: Stephane Landelle
>         Attachments: maven-filtering-test.zip
>
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> The jackrabbit config file uses a variable ${wsp.name}.
> This variable name is already used by maven during filtering and holds the project name.
> As a consequence, when trying to filter the file in order for example to change the Cluster Node Id, the file gets corrupted.
> Please find test project enclosed.
> Patch is very simple : you can keep old variables for compatibility, just duplicate variable with a jackrabbit specific name such as "jr.wsp.name" and add in org.apache.jackrabbit.core.config.RepositoryConfigurationParser:
> line 62:
>     /** Name of the repository name parser variable. */
>     public static final String MAVEN_SUPPORTING_WORKSPACE_NAME_VARIABLE = "jr.wsp.name";
> line 420:
>         // add a dupplicate that supports maven filtering
>         tmpVariables.put(MAVEN_SUPPORTING_WORKSPACE_NAME_VARIABLE, name);
> This should even be done for other variables to avoid possible later collisions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.