Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 76125 invoked from network); 30 Oct 2008 11:38:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 30 Oct 2008 11:38:07 -0000 Received: (qmail 33415 invoked by uid 500); 30 Oct 2008 11:38:11 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 33378 invoked by uid 500); 30 Oct 2008 11:38:11 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 33330 invoked by uid 99); 30 Oct 2008 11:38:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Oct 2008 04:38:10 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Oct 2008 11:37:03 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8EA48234C24B for ; Thu, 30 Oct 2008 04:37:44 -0700 (PDT) Message-ID: <1855097894.1225366664583.JavaMail.jira@brutus> Date: Thu, 30 Oct 2008 04:37:44 -0700 (PDT) From: "Jukka Zitting (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Resolved: (JCR-1841) Workspace.xml can't be loaded if it has a BOM In-Reply-To: <1140845095.1225308404319.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-1841?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:all-tabpanel ] Jukka Zitting resolved JCR-1841. -------------------------------- Resolution: Fixed Fix Version/s: 1.5.0 Assignee: Jukka Zitting Good catch, thanks! Patch applied in revision 709142. > Workspace.xml can't be loaded if it has a BOM > --------------------------------------------- > > Key: JCR-1841 > URL: https://issues.apache.org/jira/browse/JCR-1841 > Project: Jackrabbit > Issue Type: Bug > Components: config, jackrabbit-core > Affects Versions: core 1.4.6, 1.5.0 > Reporter: Gr=C3=A9gory Joseph > Assignee: Jukka Zitting > Fix For: 1.5.0 > > Attachments: use_inputstream_toload_workspace_config.patch > > > I wondered if there was a specific reason why workspace.xml files are loa= ded using a FileReader instead of an InputStream in RepositoryConfig? > If the workspace.xml file has a BOM (which could happen if someone edited= the file manually with some misbehaving editor), then it can't be loaded (= "Content not allowed in prolog") - here's a little patch that fixes this. > I left the output part untouched (i.e still using a Writer) - which makes= it a little inconsistent - maybe someone with a better knowledge of the JR= FileSystem api could fix this. --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.