Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 71098 invoked from network); 29 Oct 2008 20:11:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 29 Oct 2008 20:11:35 -0000 Received: (qmail 69838 invoked by uid 500); 29 Oct 2008 20:11:40 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 69808 invoked by uid 500); 29 Oct 2008 20:11:40 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 69797 invoked by uid 99); 29 Oct 2008 20:11:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Oct 2008 13:11:40 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Oct 2008 20:10:34 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 50924234C24F for ; Wed, 29 Oct 2008 13:10:44 -0700 (PDT) Message-ID: <1266915288.1225311044328.JavaMail.jira@brutus> Date: Wed, 29 Oct 2008 13:10:44 -0700 (PDT) From: "Julian Reschke (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Commented: (JCR-1841) Workspace.xml can't be loaded if it has a BOM In-Reply-To: <1140845095.1225308404319.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-1841?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D126436= 37#action_12643637 ]=20 Julian Reschke commented on JCR-1841: ------------------------------------- Yep. I just wanted to clarify that a UTF-8 BOM is totally legal in an XML f= ile. > Workspace.xml can't be loaded if it has a BOM > --------------------------------------------- > > Key: JCR-1841 > URL: https://issues.apache.org/jira/browse/JCR-1841 > Project: Jackrabbit > Issue Type: Bug > Components: config, jackrabbit-core > Affects Versions: core 1.4.6, 1.5.0 > Reporter: Gr=C3=A9gory Joseph > Attachments: use_inputstream_toload_workspace_config.patch > > > I wondered if there was a specific reason why workspace.xml files are loa= ded using a FileReader instead of an InputStream in RepositoryConfig? > If the workspace.xml file has a BOM (which could happen if someone edited= the file manually with some misbehaving editor), then it can't be loaded (= "Content not allowed in prolog") - here's a little patch that fixes this. > I left the output part untouched (i.e still using a Writer) - which makes= it a little inconsistent - maybe someone with a better knowledge of the JR= FileSystem api could fix this. --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.