jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bart van der Schans <sch...@onehippo.com>
Subject Mssql versus sqlserver
Date Fri, 24 Oct 2008 12:36:51 GMT
Hi,

In almost all cases MS SQL Server is referred to with the schema name 
'mssql' [1,2,3,4] except for the DbDataStore [5] for which the schema is 
called 'sqlserver'. The property to set the schema is also not called 
'schema', but 'databaseType'. These kind of inconsistencies can be quite 
frustrating when trying to configure your database connections through JNDI.

Whould it be an option to align the DbDataStore configuration with the 
other database configurations in the database connection configurations?

So, instead of:

   <DataStore class="org.apache.jackrabbit.core.data.db.DbDataStore">
     <param name="url" value="java:comp/env/jdbc/repositoryDS"/>
     <param name="driver" value="javax.naming.InitialContext"/>
     <param name="databaseType" value="sqlserver"/>
   </DataStore>

You would get:

   <DataStore class="org.apache.jackrabbit.core.data.db.DbDataStore">
     <param name="url" value="java:comp/env/jdbc/repositoryDS"/>
     <param name="driver" value="javax.naming.InitialContext"/>
     <param name="schema" value="mssql"/>
   </DataStore>

Regards,
Bart


[1] 
http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/persistence/bundle/mssql.ddl
[2] 
http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/journal/mysql.ddl
[3] 
http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/persistence/db/mssql.ddl
[4] 
http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/fs/db/mysql.ddl
[5] 
http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/data/db/sqlserver.properties


Mime
View raw message