jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Boni Gopalan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (JCR-1784) OCM:The UUID of the collection elements changes on update.
Date Tue, 07 Oct 2008 07:39:44 GMT

     [ https://issues.apache.org/jira/browse/JCR-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Boni Gopalan updated JCR-1784:
------------------------------

    Attachment: JCR-1784.additional.bonigopalan

I also did a bit of code cleanup to remove some repeating code.  Basically I saw the approach
to update a Node to be :

Locate the node to  update and then update it.  So I introduce a method that takes in the
session, Node to Update and the Object to Update to as parameters and does the updating. 
This methos is called from the other facade methods that already existed for doing the updates.
 Eliminated the code duplication.

All the tests are passing.

> OCM:The UUID of the collection elements changes on update.
> ----------------------------------------------------------
>
>                 Key: JCR-1784
>                 URL: https://issues.apache.org/jira/browse/JCR-1784
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-ocm
>    Affects Versions: 1.5
>            Reporter: Boni Gopalan
>            Assignee: Christophe Lombart
>             Fix For: 1.5
>
>         Attachments: JCR-1784.additional.bonigopalan, JCR-1784.bonigopalan.patch
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> On ocm.update transaction, the  Current implementation of DefaultCollectionConverterImpl
recreates the colleciton-element nodes if there is no id field specificaiton.  This is completely
valid for majority of the cases.  But I came across a case where the colleciton element has
a uuid field.  In this case also what is happening with the current implementation is that
it drops all the elements from the old collection-elements and recreates the new ones.  The
major flip side is that now I am left with brand new UUIDs.  I think we should address the
uniqueness characteristics specified through UUID also while mapping colleciton elements.
> I have a patch and a TestCase to verify the same.  I have implemented it only for the
digester.  If people feel the approach is right I will work out an annotation based testcase
as well.  I do not think it is going to fail even with annotations.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message