Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <2114146164.1220455425683.JavaMail.jira@brutus>
Date: Wed, 3 Sep 2008 08:23:45 -0700 (PDT)
From: "Jukka Zitting (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Resolved: (JCR-1598) Problematic exception handling in
 Jackrabbit WebApp
In-Reply-To: <2049931883.1210683055782.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/JCR-1598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-1598.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5
         Assignee: Jukka Zitting

Good point. Added a ServletExceptionWithCause utility class and started using it in revision 691632.

Resolving as Fixed.

> Problematic exception handling in Jackrabbit WebApp
> ---------------------------------------------------
>
>                 Key: JCR-1598
>                 URL: https://issues.apache.org/jira/browse/JCR-1598
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-webapp
>            Reporter: Thomas Mueller
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.5
>
>
> In this project, the cause of the exception is often ignored, and only the message of the cause is used, as in:
> } catch (Exception e) {
>     log.error("Error in configuration: {}", e.toString());
>     throw new ServletException("Error in configuration: " + e.toString());
> }
> An additional problem is that when using ServletException(String message, Throwable rootCause), the rootCause is not used in printStackTrace(), that means the cause is not logged. See also: http://closingbraces.net/2007/11/27/servletexceptionrootcause/
> It is therefore better to convert 
>   throw new ServletException("Unable to create RMI repository. jcr-rmi.jar might be missing.", e);
> to
>   ServletException s = new ServletException("Unable to create RMI repository. jcr-rmi.jar might be missing.");
>   s.initCause(e);
>   throw s;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.