Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <1881101474.1222201064462.JavaMail.jira@brutus>
Date: Tue, 23 Sep 2008 13:17:44 -0700 (PDT)
From: "Christophe Lombart (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Resolved: (JCR-1758) Improvement to
 UndefinedTypeConverterImpl to map super types effectively
In-Reply-To: <1422458693.1222183544216.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/JCR-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christophe Lombart resolved JCR-1758.
-------------------------------------

    Resolution: Fixed

the patch has been applied. Unit tests are working here. Thanks for the improvement. 
Let me know if something is wrong. 


> Improvement to UndefinedTypeConverterImpl to map super types effectively
> ------------------------------------------------------------------------
>
>                 Key: JCR-1758
>                 URL: https://issues.apache.org/jira/browse/JCR-1758
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-ocm
>         Environment: Any Java Version.
>            Reporter: Boni Gopalan
>            Assignee: Christophe Lombart
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: UndefinedTypeConverterImpl.java
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Improvement to org.apache.jackrabbit.ocm.manager.atomictypeconverter.impl.UndefinedTypeConverterImpl's implementation of 
> public Value getValue(ValueFactory valueFactory, Object propValue) , used equality check of class names to decide whether Object propValue is worthy of any attempt to map to an apropriate property.  Since the purpose of the class is to provide a 'best effort' attempt to map an Object of type java.lang.Object it will be better to use 'instanceof'.  This approach will convert the specific class as well as any inherited objects.  For example using instanceof will let us map a BufferedInputStream, and any other sub classes of InputStream to a Binary Property.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.