jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1703) Oracle JNDI DataSource support
Date Tue, 09 Sep 2008 08:45:44 GMT

    [ https://issues.apache.org/jira/browse/JCR-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12629422#action_12629422
] 

Thomas Mueller commented on JCR-1703:
-------------------------------------

I think you are right. I propose the following change:

===================================================================
--- jackrabbit-core/src/main/java/org/apache/jackrabbit/core/fs/db/OracleFileSystem.java	(revision
693399)
+++ jackrabbit-core/src/main/java/org/apache/jackrabbit/core/fs/db/OracleFileSystem.java	(working
copy)
@@ -100,8 +100,6 @@
         schema = "oracle";
         driver = "oracle.jdbc.OracleDriver";
         schemaObjectPrefix = "";
-        user = "";
-        password = "";
         initialized = false;
     }
 


> Oracle JNDI DataSource support
> ------------------------------
>
>                 Key: JCR-1703
>                 URL: https://issues.apache.org/jira/browse/JCR-1703
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: core 1.4.5
>            Reporter: Stephane Landelle
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> When org.apache.jackrabbit.core.persistence.bundle.util.ConnectionFactory tries to get
a connection from a JNDI Datasource without login and pasword, if no user/password are specified,
they re retrieved as empty strings, not null, so it tries to do a ds.getConnection(user, password),
which fails. Please complete the test line 66 as :
> if ((user == null || user.length() > 0) && (password == null || password.length()
> 0)) {
> Sincerely,
> St├ęphane Landelle

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message