jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Boni Gopalan (JIRA)" <j...@apache.org>
Subject [jira] Created: (JCR-1758) Improvement to org.apache.jackrabbit.ocm.manager.atomictypeconverter.impl.UndefinedTypeConverterImpl to map super types effectively
Date Tue, 23 Sep 2008 15:25:44 GMT
Improvement to org.apache.jackrabbit.ocm.manager.atomictypeconverter.impl.UndefinedTypeConverterImpl
to map super types effectively
-----------------------------------------------------------------------------------------------------------------------------------

                 Key: JCR-1758
                 URL: https://issues.apache.org/jira/browse/JCR-1758
             Project: Jackrabbit
          Issue Type: Improvement
          Components: jackrabbit-ocm
    Affects Versions: 1.5
         Environment: Any Java Version.
            Reporter: Boni Gopalan
            Priority: Minor
             Fix For: 1.5


Improvement to org.apache.jackrabbit.ocm.manager.atomictypeconverter.impl.UndefinedTypeConverterImpl's
implementation of 
public Value getValue(ValueFactory valueFactory, Object propValue) , used equality check of
class names to decide whether Object propValue is worthy of any attempt to map to an apropriate
property.  Since the purpose of the class is to provide a 'best effort' attempt to map an
Object of type java.lang.Object it will be better to use 'instanceof'.  This approach will
convert the specific class as well as any inherited objects.  For example using instanceof
will let us map a BufferedInputStream, and any other sub classes of InputStream to a Binary
Property.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message