Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 83630 invoked from network); 5 Aug 2008 12:07:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Aug 2008 12:07:38 -0000 Received: (qmail 72591 invoked by uid 500); 5 Aug 2008 12:07:36 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 72557 invoked by uid 500); 5 Aug 2008 12:07:36 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 72546 invoked by uid 99); 5 Aug 2008 12:07:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Aug 2008 05:07:36 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Aug 2008 12:06:48 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 14F97234C189 for ; Tue, 5 Aug 2008 05:06:46 -0700 (PDT) Message-ID: <834031710.1217938006084.JavaMail.jira@brutus> Date: Tue, 5 Aug 2008 05:06:46 -0700 (PDT) From: "Stephane Landelle (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Commented: (JCR-1703) Oracle JNDI DataSource support In-Reply-To: <1359483126.1217840145170.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-1703?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D126198= 62#action_12619862 ]=20 Stephane Landelle commented on JCR-1703: ---------------------------------------- Oups, I meant : if ((user =3D=3D null || user.length() =3D=3D 0) && (password =3D=3D null |= | password.length() =3D=3D 0)) { > Oracle JNDI DataSource support > ------------------------------ > > Key: JCR-1703 > URL: https://issues.apache.org/jira/browse/JCR-1703 > Project: Jackrabbit > Issue Type: Bug > Components: jackrabbit-core > Affects Versions: core 1.4.5 > Reporter: Stephane Landelle > Original Estimate: 0.08h > Remaining Estimate: 0.08h > > When org.apache.jackrabbit.core.persistence.bundle.util.ConnectionFactory= tries to get a connection from a JNDI Datasource without login and pasword= , if no user/password are specified, they re retrieved as empty strings, no= t null, so it tries to do a ds.getConnection(user, password), which fails. = Please complete the test line 66 as : > if ((user =3D=3D null || user.length() > 0) && (password =3D=3D null || p= assword.length() > 0)) { > Sincerely, > St=C3=A9phane Landelle --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.