Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 20304 invoked from network); 12 Aug 2008 13:51:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Aug 2008 13:51:37 -0000 Received: (qmail 17896 invoked by uid 500); 12 Aug 2008 13:51:35 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 17693 invoked by uid 500); 12 Aug 2008 13:51:34 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 17682 invoked by uid 99); 12 Aug 2008 13:51:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Aug 2008 06:51:34 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Aug 2008 13:50:47 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id C2EB5234C1A8 for ; Tue, 12 Aug 2008 06:50:44 -0700 (PDT) Message-ID: <1079506236.1218549044797.JavaMail.jira@brutus> Date: Tue, 12 Aug 2008 06:50:44 -0700 (PDT) From: "Esteban Franqueiro (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Commented: (JCR-1525) Jackrabbit depends on Oracle driver for BLOB support in Oracle versions previous than 10.2 In-Reply-To: <486085487.1207593924880.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621820#action_12621820 ] Esteban Franqueiro commented on JCR-1525: ----------------------------------------- Hi all. What should we do regarding this issue? I've been running this code for some time now and haven't had any issues. Should we apply it to trunk? Or should we wait? Regards, > Jackrabbit depends on Oracle driver for BLOB support in Oracle versions previous than 10.2 > ------------------------------------------------------------------------------------------ > > Key: JCR-1525 > URL: https://issues.apache.org/jira/browse/JCR-1525 > Project: Jackrabbit > Issue Type: Improvement > Components: jackrabbit-core > Reporter: Esteban Franqueiro > Attachments: JCR-1525.patch > > > In Oracle versions previous to 10.2, Jackrabbit explicitly uses a class from the Oracle driver to provide BLOB support (see OracleFileSystem.init()). This special handling is no longer necesary for Oracle 10.2+, so we should provide a new implementation. As discussed on the list, we can create a new class for Oracle 10.2+, make it inherit from DbFileSystem, and override the createSchema(), and table space related methods, which are the ones that need special handling. Furthermore, we could refactor the current OracleFileSystem and break it into two clases, one of them to keep the current behavior and a new one to keep the common code (which we could rename to OracleBaseFileSystem or similar, to maintain compatiblity with code that uses OracleFileSystem for versions previous to 10.2). Then we make the Oracle10FileSystem inherit from the latter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.