jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Mueller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1703) Oracle JNDI DataSource support
Date Mon, 18 Aug 2008 17:23:44 GMT

    [ https://issues.apache.org/jira/browse/JCR-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623409#action_12623409
] 

Thomas Mueller commented on JCR-1703:
-------------------------------------

If we do that, then an empty ("") user name and password are not supported any longer.

> if no user/password are specified, they re retrieved as empty strings, not null

I could not reproduce this. In my test case, both the user name and password are null:

<DataStore class="org.apache.jackrabbit.core.data.db.DbDataStore">
    <param name="url" value="jdbc:h2:~/db/datastore"/>
</DataStore>

Could you provide a test case where user name and password are an empty string in this method,
without setting the user name and password properties in the repository.xml / workspace.xml?


> Oracle JNDI DataSource support
> ------------------------------
>
>                 Key: JCR-1703
>                 URL: https://issues.apache.org/jira/browse/JCR-1703
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-core
>    Affects Versions: core 1.4.5
>            Reporter: Stephane Landelle
>   Original Estimate: 0.08h
>  Remaining Estimate: 0.08h
>
> When org.apache.jackrabbit.core.persistence.bundle.util.ConnectionFactory tries to get
a connection from a JNDI Datasource without login and pasword, if no user/password are specified,
they re retrieved as empty strings, not null, so it tries to do a ds.getConnection(user, password),
which fails. Please complete the test line 66 as :
> if ((user == null || user.length() > 0) && (password == null || password.length()
> 0)) {
> Sincerely,
> St├ęphane Landelle

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message