Return-Path: Delivered-To: apmail-jackrabbit-dev-archive@www.apache.org Received: (qmail 89526 invoked from network); 27 Jul 2008 07:48:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Jul 2008 07:48:53 -0000 Received: (qmail 52670 invoked by uid 500); 27 Jul 2008 07:48:51 -0000 Delivered-To: apmail-jackrabbit-dev-archive@jackrabbit.apache.org Received: (qmail 52636 invoked by uid 500); 27 Jul 2008 07:48:51 -0000 Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@jackrabbit.apache.org Delivered-To: mailing list dev@jackrabbit.apache.org Received: (qmail 52625 invoked by uid 99); 27 Jul 2008 07:48:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Jul 2008 00:48:51 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Jul 2008 07:48:05 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id AB947234C17D for ; Sun, 27 Jul 2008 00:48:31 -0700 (PDT) Message-ID: <1764503794.1217144911701.JavaMail.jira@brutus> Date: Sun, 27 Jul 2008 00:48:31 -0700 (PDT) From: "fabrizio giustina (JIRA)" To: dev@jackrabbit.apache.org Subject: [jira] Commented: (JCR-1644) make NamespaceContext#getPrefix(java.lang.String) iterative instead of recursive In-Reply-To: <2117127790.1212923385750.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/JCR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617250#action_12617250 ] fabrizio giustina commented on JCR-1644: ---------------------------------------- In order to successfully import s large xml file I had to patch bot getPrefix() and getURI() using iteration as suggested by Philippe, no other way to make jackrabbit handle it... Can I suggest to change this improvement to a bug "Unable to import large xml files"? > make NamespaceContext#getPrefix(java.lang.String) iterative instead of recursive > -------------------------------------------------------------------------------- > > Key: JCR-1644 > URL: https://issues.apache.org/jira/browse/JCR-1644 > Project: Jackrabbit > Issue Type: Improvement > Components: jackrabbit-core > Reporter: Philippe Marschall > Priority: Minor > Attachments: NamespaceContext.java, NamespaceContext.java.patch > > > Currently the method org.apache.jackrabbit.core.xml.NamespaceContext#getPrefix(java.lang.String) uses recursion. For very large XML files (50 MB Magnolia website exports) this causes a stack overflow. The method can easily be rewritten using iteration. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.