jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "fabrizio giustina (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1644) make NamespaceContext#getPrefix(java.lang.String) iterative instead of recursive
Date Tue, 29 Jul 2008 06:06:32 GMT

    [ https://issues.apache.org/jira/browse/JCR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617715#action_12617715
] 

fabrizio giustina commented on JCR-1644:
----------------------------------------

thanks Jukka

> What on earth are you doing with 5000 levels of nested elements?

well, as said that is what I got when trying to create a simple testcase in order to reproduce
the problem, but in a real case I can successfully reproduce it with a 100MB system view file
with only (just checked) approximatively 30-40 levels of nesting... probably the problem is
triggered by some other factors I couldn't reproduce in a test


> make NamespaceContext#getPrefix(java.lang.String) iterative instead of recursive
> --------------------------------------------------------------------------------
>
>                 Key: JCR-1644
>                 URL: https://issues.apache.org/jira/browse/JCR-1644
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, xml
>    Affects Versions: core 1.4.5
>            Reporter: Philippe Marschall
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: JCR-1644-patch.diff, NamespaceContext.java, NamespaceContext.java.patch
>
>
> Currently the method org.apache.jackrabbit.core.xml.NamespaceContext#getPrefix(java.lang.String)
uses recursion. For very large XML files (50 MB Magnolia website exports) this causes a stack
overflow. The method can easily be rewritten using iteration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message