jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philippe Marschall (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1644) make NamespaceContext#getPrefix(java.lang.String) iterative instead of recursive
Date Tue, 29 Jul 2008 17:37:31 GMT

    [ https://issues.apache.org/jira/browse/JCR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617871#action_12617871
] 

Philippe Marschall commented on JCR-1644:
-----------------------------------------

I am absolutely positive that it was a stack overflow:
- the exception was java.lang.StackOverflowError
- there was a stack trace in the log that was more than a dozen screens recursively in org.apache.jackrabbit.core.xml.NamespaceContext.getURI

> make NamespaceContext#getPrefix(java.lang.String) iterative instead of recursive
> --------------------------------------------------------------------------------
>
>                 Key: JCR-1644
>                 URL: https://issues.apache.org/jira/browse/JCR-1644
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core, xml
>    Affects Versions: core 1.4.5
>            Reporter: Philippe Marschall
>            Assignee: Jukka Zitting
>            Priority: Minor
>             Fix For: 1.5
>
>         Attachments: JCR-1644-patch.diff, NamespaceContext.java, NamespaceContext.java.patch
>
>
> Currently the method org.apache.jackrabbit.core.xml.NamespaceContext#getPrefix(java.lang.String)
uses recursion. For very large XML files (50 MB Magnolia website exports) this causes a stack
overflow. The method can easily be rewritten using iteration.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message