Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <908335515.1211545435958.JavaMail.jira@brutus>
Date: Fri, 23 May 2008 05:23:55 -0700 (PDT)
From: "Stephane Landelle (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Commented: (JCR-1537) ClassDescriptor.hasIdField() fails if
 id is declared in upper class
In-Reply-To: <653420428.1208190665183.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/JCR-1537?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D125993=
44#action_12599344 ]=20

Stephane Landelle commented on JCR-1537:
----------------------------------------

All good!


> ClassDescriptor.hasIdField() fails if id is declared in upper class
> -------------------------------------------------------------------
>
>                 Key: JCR-1537
>                 URL: https://issues.apache.org/jira/browse/JCR-1537
>             Project: Jackrabbit
>          Issue Type: Bug
>          Components: jackrabbit-ocm
>    Affects Versions: 1.5
>         Environment: Mac OS X, JVM 1.5
>            Reporter: Stephane Landelle
>            Assignee: Christophe Lombart
>             Fix For: 1.5
>
>         Attachments: jackrabbit-ocm.patch
>
>   Original Estimate: 0.02h
>  Remaining Estimate: 0.02h
>
> org.apache.jackrabbit.ocm.mapper.model.ClassDescriptor.hasIdField() looks=
 up only current class and not the whole hierarchy, so it fails when the id=
 field is declared in a upper class.
> hasIdField should use getIdFieldDescriptor and not access idFieldDescript=
or field directly, as follows :
>     public boolean hasIdField() {
>    =09=09return (this.getIdFieldDescriptor() !=3D null && this
>     =09=09=09=09.getIdFieldDescriptor().isId());
>     }
> Please find patch enclosed.
> Sincerely yours,
> St=C3=A9phane Landelle

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.