Mailing-List: contact dev-help@jackrabbit.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@jackrabbit.apache.org
Message-ID: <247874571.1211375515766.JavaMail.jira@brutus>
Date: Wed, 21 May 2008 06:11:55 -0700 (PDT)
From: "Jukka Zitting (JIRA)" <jira@apache.org>
To: dev@jackrabbit.apache.org
Subject: [jira] Updated: (JCR-1310) Webdav: Drop xerces dependency
In-Reply-To: <27035562.1200388775123.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/JCR-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-1310:
-------------------------------

    Attachment: JCR-1310-jukka.patch

How about using the SerializingContentHandler class from JCR-1350? I attached (JCR-1310-jukka.patch) a modified version of your patch that uses SerializingContentHandler instead of the new o.a.j.util.xml classes.

I don't have the litmus suite or a spi2dav setup readily at hand, so I only tested this with normal "mvn clean install". Perhaps we could automate those tests somehow?

Apart from the different serialization class there are slight changes between your and my patches:

* I used the ByteArrayOutputStream directly instead of a StringRequestEntity to implement the methods in XmlRequestEntity
* I don't set the character encoding in the content type header, as currently SerializingContentHandler let's the JAXP implementation selects the default encoding
* I don't close() the ByteArrayOutputStreams

Also, should we use "application/xml" instead of "text/xml" as the XML content type?

> Webdav: Drop xerces dependency
> ------------------------------
>
>                 Key: JCR-1310
>                 URL: https://issues.apache.org/jira/browse/JCR-1310
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-webdav
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>         Attachments: JCR-1261.drop-xerces.patch, JCR-1310-jukka.patch, JCR-1310.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.