jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jukka Zitting (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (JCR-1310) Webdav: Drop xerces dependency
Date Wed, 21 May 2008 13:23:55 GMT

    [ https://issues.apache.org/jira/browse/JCR-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598639#action_12598639
] 

jukkaz edited comment on JCR-1310 at 5/21/08 6:22 AM:
-------------------------------------------------------------

How about using the SerializingContentHandler class from JCR-1350? I attached (JCR-1310-jukka.patch)
a modified version of your patch that uses SerializingContentHandler instead of the new o.a.j.util.xml
classes.

I don't have the litmus suite or a spi2dav setup readily at hand, so I only tested this with
normal "mvn clean install". Perhaps we could automate those tests somehow?

Apart from the different serialization class there are slight changes between your and my
patches:

* I used the ByteArrayOutputStream directly instead of a StringRequestEntity to implement
the methods in XmlRequestEntity
* I don't set the character encoding in the content type header, as currently SerializingContentHandler
lets the JAXP implementation select the default encoding
* I don't close() the ByteArrayOutputStreams

Also, should we use "application/xml" instead of "text/xml" as the XML content type?

      was (Author: jukkaz):
    How about using the SerializingContentHandler class from JCR-1350? I attached (JCR-1310-jukka.patch)
a modified version of your patch that uses SerializingContentHandler instead of the new o.a.j.util.xml
classes.

I don't have the litmus suite or a spi2dav setup readily at hand, so I only tested this with
normal "mvn clean install". Perhaps we could automate those tests somehow?

Apart from the different serialization class there are slight changes between your and my
patches:

* I used the ByteArrayOutputStream directly instead of a StringRequestEntity to implement
the methods in XmlRequestEntity
* I don't set the character encoding in the content type header, as currently SerializingContentHandler
let's the JAXP implementation selects the default encoding
* I don't close() the ByteArrayOutputStreams

Also, should we use "application/xml" instead of "text/xml" as the XML content type?
  
> Webdav: Drop xerces dependency
> ------------------------------
>
>                 Key: JCR-1310
>                 URL: https://issues.apache.org/jira/browse/JCR-1310
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-webdav
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>         Attachments: JCR-1261.drop-xerces.patch, JCR-1310-jukka.patch, JCR-1310.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message