jackrabbit-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "angela (JIRA)" <j...@apache.org>
Subject [jira] Commented: (JCR-1555) Add support for boolean values to QValue
Date Tue, 13 May 2008 09:14:55 GMT

    [ https://issues.apache.org/jira/browse/JCR-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596335#action_12596335

angela commented on JCR-1555:


> I personally do not really care. If Mchael really wants it, let's add it :-) 


> That being said, we are just in the process of removing fluff elsewhere, where the rational

> is to keep the API minimal. It seems adding the methods discussed here is contrary to

> that goal :-) 

... maybe. but with respect to keep the API minimal we only had creation from String
initially... so... we already compromised and extended the QValue/Factory here. adding
the extra methods for the boolean property type somehow is a logic consequence, isn't it?
i remember that i was wondering once, why it is missing.


> How about if we only added the method to QValueFactoryImpl in spi-commons? 
> An SPI implementation can use the implementation classes directly. 

no... i am not in favour of this.
adding the method to the interfaces is rather a question of consistency and maybe it is
cosmetics only. it would be convenient to have it, but not having it isn't a problem.

so. let's come to a conclusion.

> michi, thomas are in favour of the patch.
> julian wouldn't object if michi wants the method but added a concern.

is there anybody that does object?
otherwise i would add the patch (and in addition replace the QValueFactory.create(string,
int) to the new method where the type represents PropertyType.Boolean... there is one or two


> Add support for boolean values to QValue
> ----------------------------------------
>                 Key: JCR-1555
>                 URL: https://issues.apache.org/jira/browse/JCR-1555
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-spi, jackrabbit-spi-commons
>            Reporter: Michael Dürig
>            Priority: Minor
>         Attachments: JCR-1555(2).patch, JCR-1555.patch
> I suggest to add support for reading and writing boolean values to QValue and QValueFactory.
I find it strange that there is such support for the other data types but booleans must be
constructed via strings. 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message